pgsql: Fix pg_verify_checksums on Windows. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix pg_verify_checksums on Windows.
Date
Msg-id E1fvgU8-0000GN-QU@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix pg_verify_checksums on Windows.

To verify the checksums, we open the file in text mode which doesn't work
on Windows as WIN32 treats Control-Z as EOF in files opened in text mode.
This leads to "short read of block .." error in some cases.

Fix it by opening the files in the binary mode.

Author: Amit Kapila
Reviewed-by: Magnus Hagander
Backpatch-through: 11
Discussion: https://postgr.es/m/CAA4eK1+LOnzod+h85FGmyjWzXKy-XV1FYwEyP-Tky2WpD5cxwA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb60f2cb6ed8361fbf18b92d312776046d9b0103

Modified Files
--------------
src/bin/pg_verify_checksums/pg_verify_checksums.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Etsuro Fujita
Date:
Subject: pgsql: Remove extra word from src/backend/optimizer/README
Next
From: Etsuro Fujita
Date:
Subject: pgsql: Disable support for partitionwise joins in problematic cases.