pgsql: Remove bogus Assert in make_partitionedrel_pruneinfo(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove bogus Assert in make_partitionedrel_pruneinfo().
Date
Msg-id E1fnYPn-0006PK-FI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove bogus Assert in make_partitionedrel_pruneinfo().

This Assert thought that a given rel couldn't be both leaf and
non-leaf, but it turns out that in some unusual plan trees
that's wrong, so remove it.

The lack of testing for cases like that is quite concerning ---
there is little reason for confidence that there aren't other
bugs in the area.  But developing a stable test case seems
rather difficult, and in any case we don't need this Assert.

David Rowley

Discussion: https://postgr.es/m/CAJGNTeOkdk=UVuMugmKL7M=owgt4nNr1wjxMg1F+mHsXyLCzFA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/59ef49d26d2f8724d0788fea0774f786a22ca63d

Modified Files
--------------
src/backend/partitioning/partprune.c | 2 --
1 file changed, 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Doc: Correct description of amcheck example query.
Next
From: Michael Paquier
Date:
Subject: pgsql: Restrict access to reindex of shared catalogs fornon-privileged