pgsql: Avoid unnecessary use of strncpy in a couple of places in ecpg. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid unnecessary use of strncpy in a couple of places in ecpg.
Date
Msg-id E1fUGPd-0001JE-5n@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid unnecessary use of strncpy in a couple of places in ecpg.

Use of strncpy with a length limit based on the source, rather than
the destination, is non-idiomatic and draws warnings from gcc 8.
Replace with memcpy, which does exactly the same thing in these cases,
but with less chance for confusion.

Backpatch to all supported branches.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/58065f9eed68fae83ddf98c8dff24ae8f0b62f0c

Modified Files
--------------
src/interfaces/ecpg/ecpglib/descriptor.c | 2 +-
src/interfaces/ecpg/pgtypeslib/common.c  | 6 ++----
2 files changed, 3 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix some minor error-checking oversights inParseFuncOrColumn().
Next
From: Tom Lane
Date:
Subject: pgsql: Use -Wno-format-truncation and -Wno-stringop-truncation,if avai