pgsql: Fix bogus list-iteration code in pg_regress.c,affecting ecpg te - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix bogus list-iteration code in pg_regress.c,affecting ecpg te
Date
Msg-id E1fCy3i-0004I0-2l@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bogus list-iteration code in pg_regress.c, affecting ecpg tests only.

While looking at a recent buildfarm failure in the ecpg tests, I wondered
why the pg_regress output claimed the stderr part of the test failed, when
the regression diffs were clearly for the stdout part.  Looking into it,
the reason is that pg_regress.c's logic for iterating over three parallel
lists is wrong, and has been wrong since it was written: it advances the
"tag" pointer at a different place in the loop than the other two pointers.
Fix that.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c5e46c7c3b9333616de9946f8e63df1576a19800

Modified Files
--------------
src/test/regress/pg_regress.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Get still more info about Windowscan't-reattach-to-shared-memor
Next
From: Tom Lane
Date:
Subject: pgsql: Dump full memory maps around failing Windows reattach code.