pgsql: Fix state reversal after partition tuple routing - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix state reversal after partition tuple routing
Date
Msg-id E1ey1fr-0008Ic-P7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix state reversal after partition tuple routing

We make some changes to ModifyTableState and the EState it uses whenever
we route tuples to partitions; but we weren't restoring properly in all
cases, possibly causing crashes when partitions with different tuple
descriptors are targeted by tuples inserted in the same command.
Refactor some code, creating ExecPrepareTupleRouting, to encapsulate the
needed state changing logic, and have it invoked one level above its
current place (ie. put it in ExecModifyTable instead of ExecInsert);
this makes it all more readable.

Add a test case to exercise this.

We don't support having views as partitions; and since only views can
have INSTEAD OF triggers, there is no point in testing for INSTEAD OF
when processing insertions into a partitioned table.  Remove code that
appears to support this (but which is actually never relevant.)

In passing, fix location of some very confusing comments in
ModifyTableState.

Reported-by: Amit Langote
Author: Etsuro Fujita, Amit Langote
Discussion: https://postgr/es/m/0473bf5c-57b1-f1f7-3d58-455c2230bc5f@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6666ee49f49c4a6b008591aea457becffa0df041

Modified Files
--------------
src/backend/commands/copy.c            |  20 +--
src/backend/executor/nodeModifyTable.c | 230 +++++++++++++++++----------------
src/include/nodes/execnodes.h          |  12 +-
src/test/regress/expected/insert.out   |  26 ++++
src/test/regress/sql/insert.sql        |  23 ++++
5 files changed, 188 insertions(+), 123 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Generate a separate upper relation for each stage of setopplann
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Expand comment a little bit