pgsql: Document security implications of search_path and the publicsch - Mailing list pgsql-committers

Document security implications of search_path and the public schema.

The ability to create like-named objects in different schemas opens up
the potential for users to change the behavior of other users' queries,
maliciously or accidentally.  When you connect to a PostgreSQL server,
you should remove from your search_path any schema for which a user
other than yourself or superusers holds the CREATE privilege.  If you do
not, other users holding CREATE privilege can redefine the behavior of
your commands, causing them to perform arbitrary SQL statements under
your identity.  "SET search_path = ..." and "SELECT
pg_catalog.set_config(...)" are not vulnerable to such hijacking, so one
can use either as the first command of a session.  As special
exceptions, the following client applications behave as documented
regardless of search_path settings and schema privileges: clusterdb
createdb createlang createuser dropdb droplang dropuser ecpg (not
programs it generates) initdb oid2name pg_archivecleanup pg_basebackup
pg_config pg_controldata pg_ctl pg_dump pg_dumpall pg_isready
pg_receivewal pg_recvlogical pg_resetwal pg_restore pg_rewind pg_standby
pg_test_fsync pg_test_timing pg_upgrade pg_waldump reindexdb vacuumdb
vacuumlo.  Not included are core client programs that run user-specified
SQL commands, namely psql and pgbench.  PostgreSQL encourages non-core
client applications to do likewise.

Document this in the context of libpq connections, psql connections,
dblink connections, ECPG connections, extension packaging, and schema
usage patterns.  The principal defense for applications is "SELECT
pg_catalog.set_config('search_path', '', false)", and the principal
defense for databases is "REVOKE CREATE ON SCHEMA public FROM PUBLIC".
Either one is sufficient to prevent attack.  After a REVOKE, consider
auditing the public schema for objects named like pg_catalog objects.

Authors of SECURITY DEFINER functions use some of the same defenses, and
the CREATE FUNCTION reference page already covered them thoroughly.
This is a good opportunity to audit SECURITY DEFINER functions for
robust security practice.

Back-patch to 9.3 (all supported versions).

Reviewed by Michael Paquier and Jonathan S. Katz.  Reported by Arseniy
Sharoglazov.

Security: CVE-2018-1058

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5770172cb0c9df9e6ce27c507b449557e5b45124

Modified Files
--------------
doc/src/sgml/config.sgml         | 10 +++--
doc/src/sgml/contrib.sgml        |  2 +-
doc/src/sgml/dblink.sgml         | 36 ++++++++++-----
doc/src/sgml/ddl.sgml            | 94 ++++++++++++++++++++++++++++------------
doc/src/sgml/ecpg.sgml           | 29 +++++++++++++
doc/src/sgml/extend.sgml         | 56 +++++++++++++++++-------
doc/src/sgml/libpq.sgml          | 82 ++++++++++++++++++++++++++++-------
doc/src/sgml/lobj.sgml           | 11 +++++
doc/src/sgml/ref/pgbench.sgml    | 11 +++++
doc/src/sgml/ref/psql-ref.sgml   | 12 +++++
doc/src/sgml/user-manag.sgml     | 15 ++++---
src/test/examples/testlibpq.c    | 21 ++++++---
src/test/examples/testlibpq2.c   | 29 +++++++++----
src/test/examples/testlibpq2.sql |  4 +-
src/test/examples/testlibpq3.c   | 13 +++++-
src/test/examples/testlibpq3.sql |  3 +-
src/test/examples/testlibpq4.c   | 19 ++++++--
src/test/examples/testlo.c       | 11 +++++
src/test/examples/testlo64.c     | 11 +++++
19 files changed, 369 insertions(+), 100 deletions(-)