pgsql: Fix another instance of unsafe coding for shm_toc_lookupfailure - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix another instance of unsafe coding for shm_toc_lookupfailure
Date
Msg-id E1ehkoZ-0005uW-43@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure
List pgsql-committers
Fix another instance of unsafe coding for shm_toc_lookup failure.

One or another author of commit 5bcf389ec seems to have thought that
computing an offset from a NULL pointer would yield another NULL pointer.
There may possibly be architectures where that works, but common machines
don't work like that.  Per a quick code review of places calling
shm_toc_lookup and not using noError = false.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d59ff4ab3111f20054425d82dab1393101dcfe8e

Modified Files
--------------
src/backend/executor/nodeHash.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: First-draft release notes for 10.2.
Next
From: Thomas Munro
Date:
Subject: Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure