pgsql: Fix EXPLAIN ANALYZE output for Parallel Hash. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix EXPLAIN ANALYZE output for Parallel Hash.
Date
Msg-id E1eW8mO-00039O-Ts@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix EXPLAIN ANALYZE output for Parallel Hash.

In a race case, EXPLAIN ANALYZE could fail to display correct nbatch
and size information.  Refactor so that participants report only on
batches they worked on rather than trying to report on all of them,
and teach explain.c to consider the HashInstrumentation object from
all participants instead of picking the first one it can find.  This
should fix an occasional build farm failure in the "join" regression
test.

Author: Thomas Munro
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/30219.1514428346%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/93ea78b17c4743c2b63edb5998fb5796ae57e289

Modified Files
--------------
src/backend/commands/explain.c      | 79 ++++++++++++++++++++++++-------------
src/backend/executor/nodeHash.c     | 27 +++++--------
src/backend/executor/nodeHashjoin.c |  6 ---
src/include/executor/nodeHash.h     |  1 -
4 files changed, 62 insertions(+), 51 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: In tests, await an LSN no later than the recovery target.
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Add parallel-aware hash joins.