pgsql: Fix corner-case coredump in _SPI_error_callback(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix corner-case coredump in _SPI_error_callback().
Date
Msg-id E1eOVii-0000ec-WC@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix corner-case coredump in _SPI_error_callback().

I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,
and only fills it in some time later.  If an error were to happen in
between, _SPI_error_callback would try to dereference the null pointer.
This is unlikely --- there's not much between those points except
push-snapshot calls --- but it's clearly not impossible.  Tweak the
callback to do nothing if the pointer isn't set yet.

It's been like this for awhile, so back-patch to all supported branches.

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c26d46ff6d6e10e8ac1ecf80f8cf9014e3efe418

Modified Files
--------------
src/backend/executor/spi.c | 3 +++
1 file changed, 3 insertions(+)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Improve comment about PartitionBoundInfoData.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix corner-case coredump in _SPI_error_callback().