pgsql: Fix ReinitializeParallelDSM to tolerate finding no errorqueues. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Fix ReinitializeParallelDSM to tolerate finding no errorqueues.
Date
Msg-id E1eJjZw-0003hr-E2@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix ReinitializeParallelDSM to tolerate finding no error queues.

Commit d4663350646ca0c069a36d906155a0f7e3372eb7 changed things so
that shm_toc_lookup would fail with an error rather than silently
returning NULL in the hope that such failures would be reported
in a useful way rather than via a system crash.  However, it
overlooked the fact that the lookup of PARALLEL_KEY_ERROR_QUEUE
in ReinitializeParallelDSM is expected to fail when no DSM segment
was created in the first place; in that case, we end up with a
backend-private memory segment that still contains an entry for
PARALLEL_KEY_FIXED but no others.  Consequently a benign failure
to initialize parallelism can escalate into an elog(ERROR);
repair.

Discussion: http://postgr.es/m/CA+Tgmob8LFw55DzH1QEREpBEA9RJ_W_amhBFCVZ6WMwUhVpOqg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/445dbd82a3192c6f4d15de012333943882020904

Modified Files
--------------
src/backend/access/transam/parallel.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Teach bitmap heap scan to cope with absence of a DSA.
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: PL/Python: Fix potential NULL pointer dereference