[COMMITTERS] pgsql: Improve implementation of CRE-stack-flattening inmap_variable_a - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Improve implementation of CRE-stack-flattening inmap_variable_a
Date
Msg-id E1e3409-0008Qf-HW@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve implementation of CRE-stack-flattening in map_variable_attnos().

I (tgl) objected to the obscure implementation introduced in commit
1c497fa72.  This one seems a bit less action-at-a-distance-y, at the
price of repeating a few lines of code.

Improve the comments about what the function is doing, too.

Amit Khandekar, whacked around a bit more by me

Discussion: https://postgr.es/m/CAJ3gD9egYTyHUH0nTMxm8-1m3RvdqEbaTyGC-CUNtYf7tKNDaQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/73937119bfd07a140da4817f5ca949351942ffdc

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 101 ++++++++++++++++++++-----------------
1 file changed, 55 insertions(+), 46 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Rely on sizeof(typename) rather than sizeof(variable) inpqforma
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.