[COMMITTERS] pgsql: Improve pg_regress's error reporting for schedule-fileproblems. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Improve pg_regress's error reporting for schedule-fileproblems.
Date
Msg-id E1e0xCy-0000OF-6B@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve pg_regress's error reporting for schedule-file problems.

The previous coding here trashed the line buffer as it scanned it,
making it impossible to print the source line in subsequent error
messages.  With a few save/restore/strdup pushups we can improve
that situation.

In passing, move the free'ing of the various strings that are collected
while processing one set of tests down to the bottom of the loop.
That's simpler, less surprising, and should make valgrind less unhappy
about the strings that were previously leaked by the last iteration.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b11f0d36b224a9673863b4e592f40f179dba3016

Modified Files
--------------
src/test/regress/pg_regress.c | 62 +++++++++++++++++++++++++------------------
1 file changed, 36 insertions(+), 26 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Enforce our convention about max number of parallel regressiont
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Reduce "X = X" to "X IS NOT NULL", if it's easy to do so.