[COMMITTERS] pgsql: Fix access-off-end-of-array in clog.c. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix access-off-end-of-array in clog.c.
Date
Msg-id E1e0VMh-0008Gy-WB@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix access-off-end-of-array in clog.c.

Sloppy loop coding in set_status_by_pages() resulted in fetching one array
element more than it should from the subxids[] array.  The odds of this
resulting in SIGSEGV are pretty small, but we've certainly seen that happen
with similar mistakes elsewhere.  While at it, we can get rid of an extra
TransactionIdToPage() calculation per loop.

Per report from David Binderman.  Back-patch to all supported branches,
since this code is quite old.

Discussion: https://postgr.es/m/HE1PR0802MB2331CBA919CBFFF0C465EB429C710@HE1PR0802MB2331.eurprd08.prod.outlook.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4c20ee5f27a2edbf89273e44eb369fd92d4fe3b2

Modified Files
--------------
src/backend/access/transam/clog.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Run coverage commands quietly
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix access-off-end-of-array in clog.c.