Assume wcstombs(), towlower(), and sibling functions are always present.
These functions are required by SUS v2, which is our minimum baseline
for Unix platforms, and are present on all interesting Windows versions
as well. Even our oldest buildfarm members have them. Thus, we were not
testing the "!USE_WIDE_UPPER_LOWER" code paths, which explains why the bug
fixed in commit e6023ee7f escaped detection. Per discussion, there seems
to be no more real-world value in maintaining this option. Hence, remove
the configure-time tests for wcstombs() and towlower(), remove the
USE_WIDE_UPPER_LOWER symbol, and remove all the !USE_WIDE_UPPER_LOWER code.
There's not actually all that much of the latter, but simplifying the #if
nests is a win in itself.
Discussion: https://postgr.es/m/20170921052928.GA188913@rfd.leadboat.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/85feb77aa09cda9ff3e12cf95c757c499dc25343
Modified Files
--------------
configure | 2 +-
configure.in | 2 +-
src/backend/regex/regc_pg_locale.c | 46 +++++++++-----------------------------
src/backend/tsearch/regis.c | 5 -----
src/backend/tsearch/ts_locale.c | 9 --------
src/backend/tsearch/wparser_def.c | 40 ---------------------------------
src/backend/utils/adt/formatting.c | 6 -----
src/backend/utils/adt/pg_locale.c | 5 +----
src/include/c.h | 8 -------
src/include/pg_config.h.in | 6 -----
src/include/pg_config.h.win32 | 6 -----
src/include/tsearch/ts_locale.h | 20 ++++-------------
src/include/utils/pg_locale.h | 2 --
13 files changed, 18 insertions(+), 139 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
