[COMMITTERS] pgsql: Remove duplicate reads from the inner loops in generic atomicop - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Remove duplicate reads from the inner loops in generic atomicop
Date
Msg-id E1dpexV-0002qN-Hy@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove duplicate reads from the inner loops in generic atomic ops.

The pg_atomic_compare_exchange_xxx functions are defined to update
*expected to whatever they read from the target variable.  Therefore,
there's no need to do additional explicit reads after we've initialized
the "old" variable.  The actual benefit of this is somewhat debatable,
but it seems fairly unlikely to hurt anything, especially since we
will override the generic implementations in most performance-sensitive
cases.

Yura Sokolov, reviewed by Jesper Pedersen and myself

Discussion: https://postgr.es/m/7f65886daca545067f82bf2b463b218d@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e530be96859eb0a0e0bab98a79029268ddc98a1d

Modified Files
--------------
src/include/port/atomics/generic.h | 72 +++++++++++++-------------------------
1 file changed, 24 insertions(+), 48 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: doc: Make function synopsis formatting more uniform
Next
From: Simon Riggs
Date:
Subject: [COMMITTERS] pgsql: Allow SET STATISTICS on expression indexes