[COMMITTERS] pgsql: Make [U]INT64CONST safe for use in #if conditions. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Make [U]INT64CONST safe for use in #if conditions.
Date
Msg-id E1dnrP5-0007at-U1@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make [U]INT64CONST safe for use in #if conditions.

Instead of using a cast to force the constant to be the right width,
assume we can plaster on an L, UL, LL, or ULL suffix as appropriate.
The old approach to this is very hoary, dating from before we were
willing to require compilers to have working int64 types.

This fix makes the PG_INT64_MIN, PG_INT64_MAX, and PG_UINT64_MAX
constants safe to use in preprocessor conditions, where a cast
doesn't work.  Other symbolic constants that might be defined using
[U]INT64CONST are likewise safer than before.

Also fix the SIZE_MAX macro to be similarly safe, if we are forced
to provide a definition for that.  The test added in commit 2e70d6b5e
happens to do what we want even with the hack "(size_t) -1" definition,
but we could easily get burnt on other tests in future.

Back-patch to all supported branches, like the previous commits.

Discussion: https://postgr.es/m/15883.1504278595@sss.pgh.pa.us

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/53863ebeba5fa103022c5fe47cd35314b952be59

Modified Files
--------------
configure                     | 25 -------------------------
configure.in                  | 13 -------------
src/include/c.h               | 19 +++++++++----------
src/include/pg_config.h.in    |  4 ----
src/include/pg_config.h.win32 |  8 +-------
5 files changed, 10 insertions(+), 59 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: doc: Remove mentions of server-side CRL and CA file names
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Tighten up some code in RelationBuildPartitionDesc.