[COMMITTERS] pgsql: Fix inadequacies in recently added wait events - Mailing list pgsql-committers

From Alvaro Herrera
Subject [COMMITTERS] pgsql: Fix inadequacies in recently added wait events
Date
Msg-id E1dfALx-0003oL-Sq@gemulon.postgresql.org
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events
List pgsql-committers
Fix inadequacies in recently added wait events

In commit 9915de6c1cb2, we introduced a new wait point for replication
slots and incorrectly labelled it as wait event PG_WAIT_LOCK.  That's
wrong, so invent an appropriate new wait event instead, and document it
properly.

While at it, fix numerous other problems in the vicinity:
- two different walreceiver wait events were being mixed up in a single
  wait event (which wasn't documented either); split it out so that they
  can be distinguished, and document the new events properly.

- ParallelBitmapPopulate was documented but didn't exist.

- ParallelBitmapScan was not documented (I think this should be called
  "ParallelBitmapScanInit" instead.)

- Logical replication wait events weren't documented

- various symbols had been added in dartboard order in various places.
  Put them in alphabetical order instead, as was originally intended.

Discussion: https://postgr.es/m/20170808181131.mu4fjepuh5m75cyq@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/030273b7ea468ed4b3073dfd1f2ad88e3129df6a

Modified Files
--------------
doc/src/sgml/monitoring.sgml                       | 32 +++++++++++++++++--
src/backend/postmaster/pgstat.c                    | 36 +++++++++++++---------
.../libpqwalreceiver/libpqwalreceiver.c            |  4 +--
src/backend/replication/slot.c                     |  3 +-
src/include/pgstat.h                               | 16 +++++-----
5 files changed, 64 insertions(+), 27 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: [COMMITTERS] pgsql: Disclaim xmltable() support for non-UTF8 databases.
Next
From: Alvaro Herrera
Date:
Subject: [COMMITTERS] pgsql: Fix replication origin-related race conditions