[COMMITTERS] pgsql: Suppress less info in regression tests using DROP CASCADE. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Suppress less info in regression tests using DROP CASCADE.
Date
Msg-id E1dce6i-00041J-Ek@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Suppress less info in regression tests using DROP CASCADE.

DROP CASCADE doesn't currently promise to visit dependent objects in
a fixed order, so when the regression tests use it, we typically need
to suppress the details of which objects get dropped in order to have
predictable test output.  Traditionally we've done that by setting
client_min_messages higher than NOTICE, but there's a better way:
we can "\set VERBOSITY terse" in psql.  That suppresses the DETAIL
message with the object list, but we still get the basic notice telling
how many objects were dropped.  So at least the test case can verify
that the expected number of objects were dropped.

The VERBOSITY method was already in use in a few places, but run
around and use it wherever it makes sense.

Discussion: https://postgr.es/m/10766.1501608885@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8e7537261c4b7d296fc10513b93bd67dc3d415b0

Modified Files
--------------
src/test/regress/expected/alter_generic.out  |  6 +++++-
src/test/regress/expected/create_index.out   |  4 ++--
src/test/regress/expected/create_view.out    |  4 +++-
src/test/regress/expected/object_address.out |  4 +++-
src/test/regress/expected/privileges.out     |  9 +++++----
src/test/regress/expected/rowsecurity.out    | 18 +++++++++---------
src/test/regress/expected/rules.out          |  5 +++--
src/test/regress/expected/stats_ext.out      |  6 ++++--
src/test/regress/expected/typed_table.out    |  4 ----
src/test/regress/sql/alter_generic.sql       |  2 +-
src/test/regress/sql/create_index.sql        |  3 +--
src/test/regress/sql/create_view.sql         |  2 +-
src/test/regress/sql/object_address.sql      |  2 +-
src/test/regress/sql/privileges.sql          |  8 ++++----
src/test/regress/sql/rowsecurity.sql         | 16 ++++++----------
src/test/regress/sql/rules.sql               |  4 ++--
src/test/regress/sql/stats_ext.sql           |  4 ++--
src/test/regress/sql/typed_table.sql         |  7 -------
18 files changed, 52 insertions(+), 56 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Try to deliver a sane message for _create_locale() failure onWi
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Second try at getting useful errors out ofnewlocale/_create_loc