[COMMITTERS] pgsql: Again report a useful error message when walreceiver'sconnectio - Mailing list pgsql-committers

From Andres Freund
Subject [COMMITTERS] pgsql: Again report a useful error message when walreceiver'sconnectio
Date
Msg-id E1dJ5Qc-0005zZ-5N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Again report a useful error message when walreceiver's connection closes.

Since 7c4f52409a8c (merged in v10), a shutdown master is reported as
  FATAL:  unexpected result after CommandComplete: server closed the connection unexpectedly
by walsender. It used to be
  LOG:  replication terminated by primary server
  FATAL:  could not send end-of-streaming message to primary: no COPY in progress
while the old message clearly is not perfect, it's definitely better
than what's reported now.

The change comes from the attempt to handle finished COPYs without
erroring out, needed for the new logical replication, which wasn't
needed before.

There's probably better ways to handle this, but for now just
explicitly check for a closed connection.

Author: Petr Jelinek
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/f7c7dd08-855c-e4ed-41f4-d064a6c0665a@2ndquadrant.com
Backpatch: -

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5fd56b9f5b4a007a4122c313a184f78f1647c4ab

Modified Files
--------------
.../replication/libpqwalreceiver/libpqwalreceiver.c       | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Update key words table for version 10
Next
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Use standard interrupt handling in logical replicationlauncher.