[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-versiond - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-versiond
Date
Msg-id E1dFRuG-0008LT-5d@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs.

pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching
version number in pg_control, and that seems like an important thing to
preserve since recovering from corrupt pg_control is a prime reason to
need to run it.  However, that means you can try to run it against a
data directory of a different major version, which is at best useless
and at worst disastrous.  So as to provide some protection against that
type of pilot error, inspect PG_VERSION at startup and refuse to do
anything if it doesn't match.  PG_VERSION is read-only after initdb,
so it's unlikely to get corrupted, and even if it were corrupted it would
be easy to fix by hand.

This hazard has been there all along, so back-patch to all supported
branches.

Michael Paquier, with some kibitzing by me

Discussion: https://postgr.es/m/f4b8eb91-b934-8a0d-b3cc-68f06e2279d1@enterprisedb.com

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9ed68f64114e357f958cd80ba574413b097a2c12

Modified Files
--------------
doc/src/sgml/ref/pg_resetxlog.sgml  |  5 +++
src/bin/pg_resetxlog/pg_resetxlog.c | 70 ++++++++++++++++++++++++++++++++++++-
2 files changed, 74 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Make edge-case behavior of jsonb_populate_record matchjson_popu