[COMMITTERS] pgsql: Avoid locale-dependent output in select_views regression test. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Avoid locale-dependent output in select_views regression test.
Date
Msg-id E1dF3Ik-0003dV-BT@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid locale-dependent output in select_views regression test.

Use 'COLLATE "C"' to force locale-independent sorting of the iexit
view results in select_views.sql.  We aren't particularly interested
in the exact sorting behavior here, and this doesn't change the shape
of the generated plan, so it seems like a wash as far as the goals
of this test go.

This is in response to bug #14637 from Tomasz Kontusz.  It doesn't
fully resolve his problem, because he also saw some diffs in the
create_index test.  But other people have had issues with select_views
too, and this fix lets us drop the select_views_1.out variant expected
file altogether, which is a nice win from a maintenance standpoint.

Emre Hasegeli

Discussion: https://postgr.es/m/20170501000609.24360.24248@wrigleys.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eac0a6c7d35dee6d4329b3c7d8bf82fac4c1eff1

Modified Files
--------------
src/test/regress/expected/select_views.out   |    2 +-
src/test/regress/expected/select_views_1.out | 1552 --------------------------
src/test/regress/sql/select_views.sql        |    2 +-
3 files changed, 2 insertions(+), 1554 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix typo in pg_dump's support for dumping collations frompre-v1
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Improve v10 release notes' discussion of money operatorchanges.