[COMMITTERS] pgsql: Fix table syncing with different column order - Mailing list pgsql-committers

From Peter Eisentraut
Subject [COMMITTERS] pgsql: Fix table syncing with different column order
Date
Msg-id E1dDg7z-0001LG-E3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix table syncing with different column order

Logical replication supports replicating between tables with different
column order.  But this failed for the initial table sync because of a
logic error in how the column list for the internal COPY command was
composed.  Fix that and also add a test.

Also fix a minor omission in the column name mapping cache.  When
creating the mapping list, it would not skip locally dropped columns.
So if a remote column had the same name as a locally dropped
column (...pg.dropped...), then the expected error would not occur.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/073ce405d68355eed36a11b41e558232ecf18201

Modified Files
--------------
src/backend/replication/logical/relation.c  |  9 +++++++--
src/backend/replication/logical/tablesync.c | 16 +++-------------
src/test/subscription/t/001_rep_changes.pl  | 15 +++++++++++++--
3 files changed, 23 insertions(+), 17 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Improve logical replication worker log messages
Next
From: Heikki Linnakangas
Date:
Subject: [COMMITTERS] pgsql: Abort authentication if the client selected an invalid SASLmech