[pgadmin-hackers] pgAdmin 4 commit: Make feature test app teardown more reliable,and tes - Mailing list pgadmin-hackers

Make feature test app teardown more reliable, and tests faster

    - don't spin up app and chromedriver between each test
    - catching signals also tears down the app
    - do layout reset between tests, but assume that tests will not leave a modal opened.

 Use selenium built-in waiting function and fix flakiness around clicking the alertify OK button

    - we think the OK button does not have its event bound when it is created.

If you see more flakiness around clicking the alertify OK button, let us know. The element is clickable but we have to
arbitrarilywait for the event to be bound and that timing may vary system to system. 

The feature tests are about 7 seconds faster now.

Tira & Joao

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e89c54c15d9ed8d772ffcfef1f6c2f64aa00499f
Author: Atira Odhner <aodhner@pivotal.io>

Modified Files
--------------
.../connect_to_server_feature_test.py              |  1 -
.../template_selection_feature_test.py             |  2 -
web/pgadmin/utils/route.py                         |  4 ++
web/regression/feature_utils/base_feature_test.py  | 11 ++--
web/regression/feature_utils/pgadmin_page.py       | 76 +++++++++++++---------
web/regression/runtests.py                         | 20 ++++--
web/regression/test_utils.py                       |  7 +-
7 files changed, 71 insertions(+), 50 deletions(-)