[COMMITTERS] pgsql: Fix interaction of partitioned tables with BulkInsertState. - Mailing list pgsql-committers

From Robert Haas
Subject [COMMITTERS] pgsql: Fix interaction of partitioned tables with BulkInsertState.
Date
Msg-id E1cW1UY-0007i3-7A@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix interaction of partitioned tables with BulkInsertState.

When copying into a partitioned table, the target heap may change from
one tuple to next.  We must ask ReadBufferBI() to get a new buffer
every time such change occurs.  To do that, use new function
ReleaseBulkInsertStatePin().  This fixes the bug that tuples ended up
being inserted into the wrong partition, which occurred exactly
because the wrong buffer was used.

Amit Langote, per a suggestion from Robert Haas.  Some cosmetic
adjustments by me.

Reports by 高增琦 (Gao Zengqi), Venkata B Nagothi, and
Ragnar Ouchterlony.

Discussion: http://postgr.es/m/CAFmBtr32FDOqofo8yG-4mjzL1HnYHxXK5S9OGFJ%3D%3DcJpgEW4vA%40mail.gmail.com
Discussion: http://postgr.es/m/CAEyp7J9WiX0L3DoiNcRrY-9iyw%3DqP%2Bj%3DDLsAnNFF1xT2J1ggfQ%40mail.gmail.com
Discussion: http://postgr.es/m/16d73804-c9cd-14c5-463e-5caad563ff77%40agama.tv
Discussion: http://postgr.es/m/CA+TgmoaiZpDVUUN8LZ4jv1qFE_QyR+H9ec+79f5vNczYarg5Zg@mail.gmail.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b1ecb9b3fcfb76edb3461ce561d049c8fb9e710d

Modified Files
--------------
src/backend/access/heap/heapam.c | 11 +++++++++++
src/backend/commands/copy.c      | 12 ++++++++++++
src/include/access/heapam.h      |  1 +
3 files changed, 24 insertions(+)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: [COMMITTERS] pgsql: Mention logical replication tests in src/test/README.
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Don't invoke arbitrary code inside a possibly-abortedtransactio