[COMMITTERS] pgsql: Fix minor oversights in nodeAgg.c. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix minor oversights in nodeAgg.c.
Date
Msg-id E1cJUfY-0007YS-6l@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix minor oversights in nodeAgg.c.

aggstate->evalproj is always set up by ExecInitAgg, so there's no
need to test.  Doing so led Coverity to think that we might be
intending "slot" to be possibly NULL here, and it quite properly
complained that the rest of combine_aggregates() wasn't prepared
for that.

Also fix a couple of obvious thinkos in Asserts checking that
"inputoff" isn't past the end of the slot.

Errors introduced in commit 8ed3f11bb, so no need for back-patch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c080b223a7a3991524a5287416a0ad756c15a098

Modified Files
--------------
src/backend/executor/nodeAgg.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix minor error message style violation.
Next
From: Pavel Stehule
Date:
Subject: Re: [COMMITTERS] pgsql: Simplify LWLock tranche machinery by removing array_base/array_s