pgsql: Improve pg_dump/pg_restore --create --if-exists logic. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve pg_dump/pg_restore --create --if-exists logic.
Date
Msg-id E1c7Sqa-0002hu-By@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve pg_dump/pg_restore --create --if-exists logic.

Teach it not to complain if the dropStmt attached to an archive entry
is actually spelled CREATE OR REPLACE VIEW, since that will happen due to
an upcoming bug fix.  Also, if it doesn't recognize a dropStmt, have it
print a WARNING and then emit the dropStmt unmodified.  That seems like a
much saner behavior than Assert'ing or dumping core due to a null-pointer
dereference, which is what would happen before :-(.

Back-patch to 9.4 where this option was introduced.

Discussion: <19092.1479325184@sss.pgh.pa.us>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ac888986fc656c0badb0a4918b3581e2ebcb154a

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 48 ++++++++++++++++++++++++------------
1 file changed, 32 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve pg_dump/pg_restore --create --if-exists logic.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix pg_dump's handling of circular dependencies in views.