pgsql: Allow DOS-style line endings in ~/.pgpass files. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Allow DOS-style line endings in ~/.pgpass files.
Date
Msg-id E1c6l6t-00049n-GZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow DOS-style line endings in ~/.pgpass files.

On Windows, libc will mask \r\n line endings for us, since we read the
password file in text mode.  But that doesn't happen on Unix.  People
who share password files across both systems might have \r\n line endings
in a file they use on Unix, so as a convenience, ignore trailing \r.
Per gripe from Josh Berkus.

In passing, put the existing check for empty line somewhere where it's
actually useful, ie after stripping the newline not before.

Vik Fearing, adjusted a bit by me

Discussion: <0de37763-5843-b2cc-855e-5d0e5df25807@agliodbs.com>

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/13aa9af378740795572294a800975254a969e890

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Allow DOS-style line endings in ~/.pgpass files.
Next
From: Robert Haas
Date:
Subject: pgsql: Reserve zero as an invalid DSM handle.