pgsql: Fix and simplify MSVC build's handling of xml/xslt/uuid dependen - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix and simplify MSVC build's handling of xml/xslt/uuid dependen
Date
Msg-id E1bj7uI-0005Xz-K1@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix and simplify MSVC build's handling of xml/xslt/uuid dependencies.

Solution.pm mistakenly believed that the xml option requires the xslt
option, when actually the dependency is the other way around; and it
believed that libxml requires libiconv, which is not necessarily so,
so we shouldn't enforce it here.  Fix the option cross-checking logic.

Also, since AddProject already takes care of adding libxml and libxslt
include and library dependencies to every project, there's no need
for the custom code that did that in mkvcbuild.  While at it, let's
handle the similar dependencies for uuid in a similar fashion.

Given the lack of field complaints about these overly strict build
dependency requirements, there seems no need for a back-patch.

Michael Paquier

Discussion: <CAB7nPqR0+gpu3mRQvFjf-V-bMxmiSJ6NpTg9_WzVDL+a31cV2g@mail.gmail.com>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/28e5e5648cc3666537c393b2636c4aa34fdb22c1

Modified Files
--------------
src/tools/msvc/Mkvcbuild.pm | 22 ++--------------------
src/tools/msvc/Solution.pm  | 12 +++++++-----
2 files changed, 9 insertions(+), 25 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Implement binary heap replace-top operation in a smarter way.
Next
From: Tom Lane
Date:
Subject: pgsql: Allow CREATE EXTENSION to follow extension update paths.