pgsql: Fix mdtruncate() to close fd.c handle of deleted segments. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix mdtruncate() to close fd.c handle of deleted segments.
Date
Msg-id E1bi994-0004mF-5v@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix mdtruncate() to close fd.c handle of deleted segments.

mdtruncate() forgot to FileClose() a segment's mdfd_vfd, when deleting
it. That lead to a fd.c handle to a truncated file being kept open until
backend exit.

The issue appears to have been introduced way back in 1a5c450f3024ac5,
before that the handle was closed inside FileUnlink().

The impact of this bug is limited - only VACUUM and ON COMMIT TRUNCATE
for temporary tables, truncate files in place (i.e. TRUNCATE itself is
not affected), and the relation has to be bigger than 1GB. The
consequences of a leaked fd.c handle aren't severe either.

Discussion: <20160908220748.oqh37ukwqqncbl3n@alap3.anarazel.de>
Backpatch: all supported releases

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d2a5b2b28f24e2e98a799fa8877f790ba8e68ab2

Modified Files
--------------
src/backend/storage/smgr/md.c | 1 +
1 file changed, 1 insertion(+)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix mdtruncate() to close fd.c handle of deleted segments.
Next
From: Andres Freund
Date:
Subject: pgsql: Fix mdtruncate() to close fd.c handle of deleted segments.