pgsql: Remove duplicate code from ReorderBufferCleanupTXN(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove duplicate code from ReorderBufferCleanupTXN().
Date
Msg-id E1bgi6h-0005qt-4E@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove duplicate code from ReorderBufferCleanupTXN().

Andres is apparently the only hacker who thinks this code is better as-is.
I (tgl) follow some of his logic, but the fact that it's setting off
warnings from static code analyzers seems like a sufficient reason to
put the complexity into a comment rather than the code.

Aleksander Alekseev

Discussion: <20160404190345.54d84ee8@fujitsu>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b6182081be4a795d70b966be2542ad32d1ffbc20

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add regression test coverage for non-default timezone abbreviati
Next
From: Simon Riggs
Date:
Subject: pgsql: Dirty replication slots when using sql interface