pgsql: Fix possible crash due to incorrect allocation context. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Fix possible crash due to incorrect allocation context.
Date
Msg-id E1bZiBR-0004mK-MV@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix possible crash due to incorrect allocation context.

Commit af33039317ddc4a0e38a02e2255c2bf453115fd2 aimed to reduce
leakage from tqueue.c, which is good.  Unfortunately, by changing the
memory context in which all of gather_readnext() executes, it also
changed the context in which ExecShutdownGatherWorkers executes, which
is not good, because that function eventually causes a call to
ExecParallelRetrieveInstrumentation, which proceeds to allocate
planstate->worker_instrument in a short-lived context, causing a
crash.

Rushabh Lathia, reviewed by Amit Kapila and by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/41fb35fabf03bffa812caddf24323d4d06f811ba

Modified Files
--------------
src/backend/executor/execParallel.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Fix possible crash due to incorrect allocation context.
Next
From: Tom Lane
Date:
Subject: pgsql: Automate the maintenance of SO_MINOR_VERSION for our shared libr