pgsql: Avoid crashing in GetOldestSnapshot() if there are no known snap - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid crashing in GetOldestSnapshot() if there are no known snap
Date
Msg-id E1bWSvf-0004O9-DA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid crashing in GetOldestSnapshot() if there are no known snapshots.

The sole caller expects NULL to be returned in such a case, so make
it so and document it.

Per reports from Andreas Seltenreich and Regina Obe.  This doesn't
really fix their problem, as now their RETURNING queries will say
"ERROR: no known snapshots", but in any case this function should
not dump core in a reasonably-foreseeable situation.

Report: <87vazemeda.fsf@credativ.de>
Report: <20160807051854.1427.32414@wrigleys.postgresql.org>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/07a601eedab7c5fa4d62055fa3efacef2f38e446

Modified Files
--------------
src/backend/utils/time/snapmgr.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Don't propagate a null subtransaction snapshot up to parent tran
Next
From: Tom Lane
Date:
Subject: pgsql: Fix TOAST access failure in RETURNING queries.