pgsql: Fix hard to hit race condition in heapam's tuple locking code. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix hard to hit race condition in heapam's tuple locking code.
Date
Msg-id E1bVVWt-0001Ia-2W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix hard to hit race condition in heapam's tuple locking code.

As mentioned in its commit message, eca0f1db left open a race condition,
where a page could be marked all-visible, after the code checked
PageIsAllVisible() to pin the VM, but before the page is locked.  Plug
that hole.

Reviewed-By: Robert Haas, Andres Freund
Author: Amit Kapila
Discussion: CAEepm=3fWAbWryVW9swHyLTY4sXVf0xbLvXqOwUoDiNCx9mBjQ@mail.gmail.com
Backpatch: -

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e7caacf733f3ee77a555aa715ab6fbf4434e6b52

Modified Files
--------------
src/backend/access/heap/heapam.c | 44 ++++++++++++++++++++++++++++++++++------
1 file changed, 38 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu
Next
From: Robert Haas
Date:
Subject: pgsql: Change InitToastSnapshot to a macro.