pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser - Mailing list pgadmin-hackers

From Dave Page
Subject pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser
Date
Msg-id E1bS0py-0006PM-NJ@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Property 'URL' (of type string) not quoted in browser.js template when extending pgAdmin.Browser. Fixes #1504

Without quotes, the property can be mistakenly treated as a regex:

e.g.: URL: /pgadmin/browser/,

When that happens, JS engine throws "SyntaxError: invalid regular expression flag b" and the whole web interface
freezes.
This problem usually occurs when pgadmin is hosted inside a subdirectory (https://host/pgadmin/ instead of
https://host/).

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19306934a08f786cba2cd156a14858e66602038c
Author: daze <dazemail@mailinator.com>

Modified Files
--------------
web/pgadmin/browser/templates/browser/js/browser.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: PATCH: To disable SQLALCHEMY to tracking (pgAdmin4)
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Replace 'Add' buttons with '+'