pgAdmin 4 commit: Allow creation of FDWs if the extension is in a non-d - Mailing list pgadmin-hackers

From Dave Page
Subject pgAdmin 4 commit: Allow creation of FDWs if the extension is in a non-d
Date
Msg-id E1bReMp-0003jo-79@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Allow creation of FDWs if the extension is in a non-default schema. Fixes #1320

Root cause:-

When user change schema of already created fdw extension then while creating the new fdw we should append the
<schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it will not be able to find fdw handler name
withoutschema name. 

e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema 'test' then we should display the handler
nameunder fdw as "test. postgres_fdw_handler". 

Solution:-

With this patch, we have added <schema_name>.<fdw_handler_name> so while creating or updating the fdw, proper sql will
begenerated. 

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dbd3c7f4c5dab4aafa81ade9cfe5b309c8b5cdbf
Author: Neel Patel <neel.patel@enterprisedb.com>

Modified Files
--------------
.../servers/databases/foreign_data_wrappers/__init__.py        |  4 ++--
.../templates/foreign_data_wrappers/sql/9.1_plus/create.sql    |  4 ++--
.../templates/foreign_data_wrappers/sql/9.1_plus/handlers.sql  |  5 ++++-
.../foreign_data_wrappers/sql/9.1_plus/properties.sql          | 10 +++++++---
.../templates/foreign_data_wrappers/sql/9.1_plus/update.sql    |  4 ++--
.../foreign_data_wrappers/sql/9.1_plus/validators.sql          |  5 ++++-
.../templates/foreign_data_wrappers/sql/9.3_plus/create.sql    |  4 ++--
.../templates/foreign_data_wrappers/sql/9.3_plus/handlers.sql  |  5 ++++-
.../foreign_data_wrappers/sql/9.3_plus/properties.sql          |  8 ++++++--
.../templates/foreign_data_wrappers/sql/9.3_plus/update.sql    |  4 ++--
.../foreign_data_wrappers/sql/9.3_plus/validators.sql          |  5 ++++-
11 files changed, 39 insertions(+), 19 deletions(-)


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][runtime][patch]: Compilation error with Qt4
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][patch]: Fix for RM 1320