pgsql: postgres_fdw: Fix incorrect NULL handling in join pushdown. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: postgres_fdw: Fix incorrect NULL handling in join pushdown.
Date
Msg-id E1bGWYr-0003cQ-Ck@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
postgres_fdw: Fix incorrect NULL handling in join pushdown.

something.* IS NOT NULL means that every attribute of the row is not
NULL, not that the row itself is non-NULL (e.g. because it's coming
from below an outer join.  Use (somevar.*)::pg_catalog.text IS NOT
NULL instead.

Ashutosh Bapat, per a report by Rushabh Lathia.  Reviewed by
Amit Langote and Etsuro Fujita.  Schema-qualification added by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9e9c38e15947f4f3ed478f8b70e74b55e31fe950

Modified Files
--------------
contrib/postgres_fdw/deparse.c                 |  8 ++--
contrib/postgres_fdw/expected/postgres_fdw.out | 62 +++++++++++++++++---------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  5 +++
3 files changed, 50 insertions(+), 25 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: postgres_fdw: Remove useless return statement.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix building of large (bigger than shared_buffers) hash indexes.