pgsql: Improve error message annotation for GRANT/REVOKE on untrusted P - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve error message annotation for GRANT/REVOKE on untrusted P
Date
Msg-id E1bEPpT-00023o-1G@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve error message annotation for GRANT/REVOKE on untrusted PLs.

The annotation for "ERROR: language "foo" is not trusted" used to say
"HINT: Only superusers can use untrusted languages", which was fairly
poorly thought out.  For one thing, it's not a hint about what to do,
but a statement of fact, which makes it errdetail.  But also, this
fails to clarify things much, because there's a missing step in the
chain of reasoning.  I think it's more useful to say "GRANT and REVOKE
are not allowed on untrusted languages, because only superusers can use
untrusted languages".

It's been like this for a long time, but given the lack of previous
complaints, I don't think this is worth back-patching.

Discussion: <1417.1466289901@sss.pgh.pa.us>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9bc3332372f9992875d80f856fd98999e070fe35

Modified Files
--------------
src/backend/catalog/aclchk.c             | 3 ++-
src/test/regress/expected/privileges.out | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Update 9.6 release notes through today.
Next
From: Tom Lane
Date:
Subject: pgsql: Docs: improve description of psql's %R prompt escape sequence.