pgsql: Revert "Use Foreign Key relationships to infer multi-column join - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Revert "Use Foreign Key relationships to infer multi-column join
Date
Msg-id E1bAORH-00030d-E5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Use Foreign Key relationships to infer multi-column join selectivity".

This commit reverts 137805f89 as well as the associated commits 015e88942,
5306df283, and 68d704edb.  We found multiple bugs in this feature, and
there was concern about possible planner slowdown (though to be fair,
exhibiting a very large slowdown proved difficult).  The way forward
requires a considerable rewrite, which may or may not be possible to
accomplish in time for beta2.  In my judgment reviewing the rewrite will
be easier to accomplish starting from a clean slate, so let's temporarily
revert what's there now.  This also leaves us in a safe state if it turns
out to be necessary to postpone the rewrite to the next development cycle.

Discussion: <20160429102531.GA13701@huehner.biz>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/77ba610805e7ef9ba9c9a593ea8b1ca8f98f8bcb

Modified Files
--------------
src/backend/nodes/outfuncs.c             |  13 --
src/backend/optimizer/path/costsize.c    | 375 +------------------------------
src/backend/optimizer/util/plancat.c     |  85 +------
src/backend/utils/cache/relcache.c       |  75 -------
src/backend/utils/misc/guc.c             |   9 -
src/include/nodes/nodes.h                |   1 -
src/include/nodes/relation.h             |  22 --
src/include/optimizer/cost.h             |   1 -
src/include/optimizer/paths.h            |   2 -
src/include/utils/rel.h                  |   3 -
src/include/utils/relcache.h             |   1 -
src/test/regress/expected/rangefuncs.out |  29 ++-
12 files changed, 25 insertions(+), 591 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Message style and wording fixes
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix loose ends for SQL ACCESS METHOD objects