pgsql: pg_upgrade: Improve error checking in rewriteVisibilityMap. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: pg_upgrade: Improve error checking in rewriteVisibilityMap.
Date
Msg-id E1b9syR-0004kZ-Tp@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_upgrade: Improve error checking in rewriteVisibilityMap.

In the old logic, if read() were to return an error, we'd silently stop
rewriting the visibility map at that point in the file.  That's safe,
but reporting the error is better, so do that instead.

Report by Andres Freund.  Patch by Masahiko Sawada, with one correction
by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/aba8943082f1ccbfb19f2e7ff02ba3be0fcb6c9d

Modified Files
--------------
src/bin/pg_upgrade/file.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix whitespace
Next
From: Robert Haas
Date:
Subject: pgsql: Fix typo.