pgsql: Make regression test for multiple synchronous standbys more stab - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Make regression test for multiple synchronous standbys more stab
Date
Msg-id E1aqvqz-0008Dx-Do@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make regression test for multiple synchronous standbys more stable.

The regression test checks whether the output of pg_stat_replication is
expected or not after changing synchronous_standby_names and reloading
the configuration file. Regarding this test logic, previously there was
a timing issue which made the test result unstable. That is,
pg_stat_replication could return unexpected result during small window
after the configuration file was reloaded before new setting value
took effect, and which made the test fail.

This commit changes the test logic so that it uses a loop with a timeout
to give some room for the test to pass. Now the test fails only when
pg_stat_replication keeps returning unexpected result for 30 seconds.

Michael Paquier

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/36c1c91604cee164c6487afb99508f7ff8737b96

Modified Files
--------------
src/test/recovery/t/007_sync_rep.pl | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix memory leak in GIN index scans.
Next
From: Magnus Hagander
Date:
Subject: pgsql: Update helptext for vcregress.pl