pgsql: In generic WAL application and replay, ensure page "hole" is alw - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: In generic WAL application and replay, ensure page "hole" is alw
Date
Msg-id E1aq017-0000DZ-Dk@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
In generic WAL application and replay, ensure page "hole" is always zero.

The previous coding could allow the contents of the "hole" between pd_lower
and pd_upper to diverge during replay from what it had been when the update
was originally applied.  This would pose a problem if checksums were in
use, and in any case would complicate forensic comparisons between master
and slave servers.  So force the "hole" to contain zeroes, both at initial
application of a generically-logged action, and at replay.

Alexander Korotkov, adjusted slightly by me

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bdf7db81921deb99fd9d489cbcc635906c89e215

Modified Files
--------------
src/backend/access/transam/generic_xlog.c | 40 ++++++++++++++++++++++++++++---
1 file changed, 37 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: pgsql: Add page id to bloom index
Next
From: Tom Lane
Date:
Subject: pgsql: Improve API of GenericXLogRegister().