pgsql: Get rid of GenericXLogUnregister(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Get rid of GenericXLogUnregister().
Date
Msg-id E1aozfQ-0004SW-If@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Get rid of GenericXLogUnregister().

This routine is unsafe as implemented, because it invalidates the page
image pointers returned by previous GenericXLogRegister() calls.

Rather than complicate the API or the implementation to avoid that,
let's just get rid of it; the use-case for having it seems much
too thin to justify a lot of work here.

While at it, do some wordsmithing on the SGML docs for generic WAL.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/08e785436f84f8824149a2182b0cb9ce2c28e31d

Modified Files
--------------
doc/src/sgml/generic-wal.sgml             | 121 +++++++++++++++++-------------
src/backend/access/transam/generic_xlog.c |  29 -------
src/include/access/generic_xlog.h         |   3 +-
3 files changed, 69 insertions(+), 84 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Get rid of blinsert()'s use of GenericXLogUnregister().
Next
From: Tom Lane
Date:
Subject: pgsql: Fix PL/Python ereport() test to work on Python 2.3.