pgsql: Clamp adjusted ndistinct to positive integer in estimate_hash_bu - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Clamp adjusted ndistinct to positive integer in estimate_hash_bu
Date
Msg-id E1akIqI-0006MJ-UG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Clamp adjusted ndistinct to positive integer in estimate_hash_bucketsize().

This avoids a possible divide-by-zero in the following calculation,
and rounding the number to an integer seems like saner behavior anyway.
Assuming IEEE math, the division would yield +Infinity which would get
replaced by 1.0 at the bottom of the function, so nothing really
interesting would ensue; but avoiding divide-by-zero seems like a
good idea on general principles.

Per report from Piotr Stefaniak.  No back-patch since this seems
mostly cosmetic.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fa09f8935156533584b4e215bdf70ec1ff968dad

Modified Files
--------------
src/backend/utils/adt/selfuncs.c | 3 +++
1 file changed, 3 insertions(+)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: pg_rewind: fsync target data directory.
Next
From: Tom Lane
Date:
Subject: pgsql: Guard against zero vardata.rel->tuples in estimate_hash_bucketsi