pgsql: Create src/fe_utils/, and move stuff into there from pg_dump's d - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Create src/fe_utils/, and move stuff into there from pg_dump's d
Date
Msg-id E1ajBMb-0003bO-VJ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Create src/fe_utils/, and move stuff into there from pg_dump's dumputils.

Per discussion, we want to create a static library and put the stuff into
it that until now has been shared across src/bin/ directories by ad-hoc
methods like symlinking a source file.  This commit creates the library and
populates it with a couple of files that contain the widely-useful portions
of pg_dump's dumputils.c file.  dumputils.c survives, because it has some
stuff that didn't seem appropriate for fe_utils, but it's significantly
smaller and is no longer referenced from any other directory.

Follow-on patches will move more stuff into fe_utils.

The Mkvcbuild.pm hacking here is just a best guess; we'll see how the
buildfarm likes it.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/588d963b00e5e4385b6425418e3faa726f63f72e

Modified Files
--------------
src/Makefile                         |   1 +
src/Makefile.global.in               |   7 +-
src/bin/pg_dump/Makefile             |   7 +-
src/bin/pg_dump/common.c             |  35 +-
src/bin/pg_dump/dumputils.c          | 705 +----------------------------------
src/bin/pg_dump/dumputils.h          |  63 +---
src/bin/pg_dump/parallel.c           |   1 +
src/bin/pg_dump/pg_backup.h          |   2 +-
src/bin/pg_dump/pg_backup_archiver.c |   2 +
src/bin/pg_dump/pg_backup_null.c     |   1 +
src/bin/pg_dump/pg_backup_tar.c      |   1 +
src/bin/pg_dump/pg_dump.c            |   1 +
src/bin/pg_dump/pg_dump.h            |   3 -
src/bin/pg_dump/pg_dumpall.c         |   1 +
src/bin/psql/.gitignore              |   1 -
src/bin/psql/Makefile                |  12 +-
src/bin/psql/command.c               |   2 +-
src/bin/psql/copy.c                  |   1 -
src/bin/psql/describe.c              |   2 +-
src/bin/scripts/.gitignore           |   1 -
src/bin/scripts/Makefile             |  24 +-
src/bin/scripts/clusterdb.c          |   2 +-
src/bin/scripts/createdb.c           |   2 +-
src/bin/scripts/createuser.c         |   3 +-
src/bin/scripts/dropdb.c             |   2 +-
src/bin/scripts/dropuser.c           |   2 +-
src/bin/scripts/reindexdb.c          |   3 +-
src/bin/scripts/vacuumdb.c           |   3 +-
src/fe_utils/Makefile                |  39 ++
src/fe_utils/simple_list.c           | 116 ++++++
src/fe_utils/string_utils.c          | 674 +++++++++++++++++++++++++++++++++
src/include/Makefile                 |   5 +-
src/include/fe_utils/simple_list.h   |  55 +++
src/include/fe_utils/string_utils.h  |  51 +++
src/tools/msvc/Mkvcbuild.pm          |  22 +-
35 files changed, 1004 insertions(+), 848 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Improve documentation for combine functions.
Next
From: Tom Lane
Date:
Subject: pgsql: Add missed inclusion requirement in Mkvcbuild.pm.