pgsql: Remove a couple of useless pstrdup() calls. - Mailing list pgsql-committers

Remove a couple of useless pstrdup() calls.

There's no point in pstrdup'ing the result of TextDatumGetCString,
since that's necessarily already a freshly-palloc'd C string.

These particular calls are unlikely to be of any consequence
performance-wise, but still they're a bad precedent that can confuse
future patch authors.

Noted by Chapman Flack.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cc402116ca156babcd3ef941317f462a96277e3a

Modified Files
--------------
src/backend/foreign/foreign.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)