pgsql: pgbench: cleanup use of a "logfile" parameter - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: pgbench: cleanup use of a "logfile" parameter
Date
Msg-id E1aUKNa-0001I8-Og@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pgbench: cleanup use of a "logfile" parameter

There is no reason to have the per-thread logfile file pointer as a
separate parameter in various functions: it's much simpler to put it in
the per-thread state struct instead, which is already being passed to
all functions that need the log file anyway.  Change the callsites in
which it was used as a boolean to test whether logging is active, so
that they use the use_log global variable instead.

No backpatch, even though this exists since commit a887c486d5df of March
2010, because this is just for cleanliness' sake and the surrounding
code has been modified a lot recently anyway.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/34f13cc48432fb0a70bd76116347a758b7a0bc63

Modified Files
--------------
src/bin/pgbench/pgbench.c | 44 +++++++++++++++++++++++++-------------------
1 file changed, 25 insertions(+), 19 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: pgbench: fix segfault with empty sql file
Next
From: Tom Lane
Date:
Subject: pgsql: Revert "isolationtester: don't repeat the is-it-waiting query wh