Postgres Pro
Downloads
Home   >   mailing lists

pgsql: postgres_fdw: Avoid possible misbehavior when RETURNING tableoid - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: postgres_fdw: Avoid possible misbehavior when RETURNING tableoid
Date
Msg-id E1aRX3u-0000of-B6@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
postgres_fdw: Avoid possible misbehavior when RETURNING tableoid column only.

deparseReturningList ended up adding up RETURNING NULL to the code, but
code elsewhere saw an empty list of attributes and concluded that it
should not expect tuples from the remote side.

Etsuro Fujita and Robert Haas, reviewed by Thom Brown

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2099b911d75738e18749e89019bf75f20dfde4c1

Modified Files
--------------
contrib/postgres_fdw/deparse.c                 | 18 +++++----
contrib/postgres_fdw/expected/postgres_fdw.out | 53 ++++++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql      |  9 +++++
3 files changed, 73 insertions(+), 7 deletions(-)

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: When modifying a foreign table, initialize tableoid field proper
Next
From: Robert Haas
Date:
Subject: pgsql: postgres_fdw: Avoid possible misbehavior when RETURNING tableoid