pgsql: Fix unobvious interaction between -X switch and subdirectory cre - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix unobvious interaction between -X switch and subdirectory cre
Date
Msg-id E1aHJrs-0004c5-Ll@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix unobvious interaction between -X switch and subdirectory creation.

Turns out the only reason initdb -X worked is that pg_mkdir_p won't
whine if you point it at something that's a symlink to a directory.
Otherwise, the attempt to create pg_xlog/ just like all the other
subdirectories would have failed.  Let's be a little more explicit
about what's happening.  Oversight in my patch for bug #13853
(mea culpa for not testing -X ...)

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/957e1117da128c9615e81823db2ce0bc81f8cf81

Modified Files
--------------
src/bin/initdb/initdb.c |   29 ++++++++++++++++++-----------
1 file changed, 18 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix unobvious interaction between -X switch and subdirectory cre
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix order of arguments to va_start()