pgsql: Fix regrole and regnamespace types to honor quoting like other r - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix regrole and regnamespace types to honor quoting like other r
Date
Msg-id E1aFyFQ-0001lE-CZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix regrole and regnamespace types to honor quoting like other reg* types.

Aside from any consistency arguments, this is logically necessary because
the I/O functions for these types also handle numeric OID values.  Without
a quoting rule it is impossible to distinguish numeric OIDs from role or
namespace names that happen to contain only digits.

Also change the to_regrole and to_regnamespace functions to dequote their
arguments.  While not logically essential, this seems like a good idea
since the other to_reg* functions do it.  Anyone who really wants raw
lookup of an uninterpreted name can fall back on the time-honored solution
of (SELECT oid FROM pg_namespace WHERE nspname = whatever).

Report and patch by Jim Nasby, reviewed by Michael Paquier

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/fa038f830b64779475b746a6840db9bdd0298d80

Modified Files
--------------
src/backend/utils/adt/regproc.c       |   48 ++++++++--
src/test/regress/expected/regproc.out |  169 ++++++++++++++++++++++++---------
src/test/regress/sql/regproc.sql      |   44 +++++++--
3 files changed, 201 insertions(+), 60 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix regrole and regnamespace types to honor quoting like other r
Next
From: Tom Lane
Date:
Subject: pgsql: Fix regrole and regnamespace output functions to do quoting, too