pgsql: Rename (new|old)estCommitTs to (new|old)estCommitTsXid - Mailing list pgsql-committers

From Joe Conway
Subject pgsql: Rename (new|old)estCommitTs to (new|old)estCommitTsXid
Date
Msg-id E1aDeWN-000344-Kv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rename (new|old)estCommitTs to (new|old)estCommitTsXid

The variables newestCommitTs and oldestCommitTs sound as if they are
timestamps, but in fact they are the transaction Ids that correspond
to the newest and oldest timestamps rather than the actual timestamps.
Rename these variables to reflect that they are actually xids: to wit
newestCommitTsXid and oldestCommitTsXid respectively. Also modify
related code in a similar fashion, particularly the user facing output
emitted by pg_controldata and pg_resetxlog.

Complaint and patch by me, review by Tom Lane and Alvaro Herrera.
Backpatch to 9.5 where these variables were first introduced.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/282fdfcdc8a8f987c06e839d581b94bf196def8a

Modified Files
--------------
src/backend/access/rmgrdesc/xlogdesc.c  |    4 +--
src/backend/access/transam/commit_ts.c  |   52 +++++++++++++++----------------
src/backend/access/transam/xlog.c       |   16 +++++-----
src/backend/commands/vacuum.c           |    2 +-
src/bin/pg_controldata/pg_controldata.c |    8 ++---
src/bin/pg_resetxlog/pg_resetxlog.c     |   44 +++++++++++++-------------
src/include/access/commit_ts.h          |    2 +-
src/include/access/transam.h            |    4 +--
src/include/catalog/pg_control.h        |    4 +--
9 files changed, 68 insertions(+), 68 deletions(-)


pgsql-committers by date:

Previous
From: Joe Conway
Date:
Subject: pgsql: Rename (new|old)estCommitTs to (new|old)estCommitTsXid
Next
From: Tom Lane
Date:
Subject: pgsql: Put back one copyObject() in rewriteTargetView().